RFR: 8322630: Remove ICStubs and related safepoints [v6]

Erik Ă–sterlund eosterlund at openjdk.org
Fri Feb 9 14:30:11 UTC 2024


On Thu, 8 Feb 2024 21:28:26 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Ă–sterlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   ARM32 fixes
>
> src/hotspot/cpu/arm/arm.ad line 880:
> 
>> 878: void MachUEPNode::emit(CodeBuffer &cbuf, PhaseRegAlloc *ra_) const {
>> 879:   C2_MacroAssembler _masm(&cbuf);
>> 880:   __ ic_check(CodeEntryAlignment);
> 
> Do we care about CodeEntryAlignment here if the old code didn't?

Perhaps not, but it seems weird not to align. But maybe I should use InteriorEntryAlignment here, so it's symmetric to AArch64.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1484390940


More information about the shenandoah-dev mailing list