RFR: 8322630: Remove ICStubs and related safepoints [v9]
Erik Österlund
eosterlund at openjdk.org
Mon Feb 12 10:38:03 UTC 2024
On Fri, 9 Feb 2024 21:27:58 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback from Dean and Thomas
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 1554:
>
>> 1552: __ far_jump(RuntimeAddress(SharedRuntime::get_handle_wrong_method_stub()));
>> 1553:
>> 1554: // Verified entry point must be aligned
>
> I think this comment should come around line 1539.
Okay, I will fix it.
> src/hotspot/cpu/arm/sharedRuntime_arm.cpp line 823:
>
>> 821: __ ic_check(CodeEntryAlignment /* end_alignment */);
>> 822:
>> 823: int vep_offset = __ pc() - start;
>
> Maybe add back
> `// Verified entry point`
> above this line.
Sure.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1485997296
PR Review Comment: https://git.openjdk.org/jdk/pull/17495#discussion_r1485997474
More information about the shenandoah-dev
mailing list