RFR: 8322630: Remove ICStubs and related safepoints [v9]

Erik Österlund eosterlund at openjdk.org
Tue Feb 13 09:19:17 UTC 2024


On Sat, 10 Feb 2024 00:35:47 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback from Dean and Thomas
>
> If I just look at the new code, everything looks very reasonable.  I tried to compare the new code to the old code, but quickly gave up.
> 
> Could you explain why opt_virtual can now be a direct call and CompiledIC is now only for virtual?  It seems like we could have done that even with the old code.
> 
> Also, why don't we have to check for method->is_old() anymore?

Thanks for the review, @dean-long! I pushed a trivial merge conflict with the next round of NULL -> nullptr changes. Running final round of tests now

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17495#issuecomment-1940860792


More information about the shenandoah-dev mailing list