RFR: 8324067: GenShen: Isolate regulator thread to generational mode [v2]

[Y. Srinivas Ramakrishna]

On Sat, 10 Feb 2024 00:11:44 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits:
>> 
>>  - Merge branch 'shenandoah-master' into isolate-regulator-thread
>>  - Merge remote-tracking branch 'shenandoah/master' into isolate-regulator-thread
>>  - Clean up includes
>>  - Remove unnecessary mode checks
>>  - Remove non-generational functionality from regulator thread
>>  - Move heap changed tracking from control thread to heap
>>  - Clean up includes and headers
>>  - Factor allocation failure handling methods into common base class
>>  - Merge remote-tracking branch 'shenandoah/master' into isolate-regulator-thread
>>  - Merge remote-tracking branch 'shenandoah/master' into isolate-control-thread
>>  - ... and 12 more: https://git.openjdk.org/shenandoah/compare/8f4e6e22...6915cd07
>
> src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 1:
> 
>> 1: /*
> 
> This file is largely reverted to the upstream's version.

Very nice! However, see a few comments below on some good stuff that we may not want to lose in the modifications to the original code that you are now reverting to its original form. Worth a quick check to see if it's worth fixing up separately in upstream perhaps.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/391#discussion_r1490089711