RFR: 8325671: Shenandoah: Introduce a ShenandoahGenerationType and templatize certain marking closures with it [v4]

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Feb 15 16:52:00 UTC 2024


On Thu, 15 Feb 2024 13:36:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> The change looks okay, but I do not see a good reason to introduce this into Shenandoah before Generational mode arrives. It is just extra (mostly dead) code to maintain, and it effectively hides what changes Generational needs to do in shared Shenandoah code. Maybe we should consider this as part of Generational integration PR?

Indeed the idea was to introduce this earlier that any Generational-specific code as a decomposition and refactoring of the work needed for generational mode, as I describe in the summary above, such that its effect was independently shown to be minimal & harmless, and making subsequent integration of Generational mode much smaller, simpler, and easier to review on its own.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17815#issuecomment-1946567186


More information about the shenandoah-dev mailing list