RFR: 8324067: GenShen: Isolate regulator thread to generational mode [v5]

[William Kemper]

On Wed, 14 Feb 2024 21:42:58 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix zero build some more
>
> src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 53:
> 
>> 51: 
>> 52: void ShenandoahControlThread::run_service() {
>> 53:   ShenandoahHeap* heap = ShenandoahHeap::heap();
> 
> I see that in getting back to being closer to upstream tip of Shenandoah, we have lost (amongst other things), a bunch of const's here as an example. Also some fixes to comments as well. Was the the intention?
> 
> The alternative is that these kinds of changes to upstream code could be upstreamed so that they aren't lost in trying to reconcile with legacy Shenandoah.
> 
> Thoughts?

Yes, I made most of these declarations `const` here: https://github.com/openjdk/jdk/pull/17795/files. Though for some reason, I missed the `heap` variable so I'll fix that before integrating.

> src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 260:
> 
>> 258:       }
>> 259:     } else {
>> 260:       // Allow allocators to know we have seen this much regions
> 
> "these many words allocated" was more accurate than "this much regions" in comment above.

Yes, I'll restore that change.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/391#discussion_r1491447570
PR Review Comment: https://git.openjdk.org/shenandoah/pull/391#discussion_r1491449158