RFR: 8325808: GenShen: Move generational mode code out of shFullGC.cpp

[Y. Srinivas Ramakrishna]

On Mon, 19 Feb 2024 15:38:39 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> This change reduces the differences from the upstream branch by moving large chunks of generational mode code into separate files.
>
> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.cpp line 35:
> 
>> 33: 
>> 34: 
>> 35: class ShenandoahSetRememberedCardsToDirtyClosure : public BasicOopIterateClosure {
> 
> Nit: I realize this is the existing name of the closure, and you just moved it here, but consider the following renaming suggestion: `ShenandoahDirtyRememberedSetClosure`

Nit: may be place a block comment for the closure:

// A closure that takes an oop in the old generation and, if it's
// pointing into the young generation, dirties the corresponding
// remembered set entry.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/398#discussion_r1494755034