RFR: 8325671: Shenandoah: Introduce a ShenandoahGenerationType and templatize certain marking closures with it [v6]
Roman Kennke
rkennke at openjdk.org
Wed Feb 21 20:27:55 UTC 2024
On Sat, 17 Feb 2024 01:47:09 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> 8325671: Shenandoah: Introduce a ShenandoahGenerationType and templatize certain marking closures with it
>
> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>
> - Merge branch 'master' into generation_type
> - Changes from review: Adjust order of parms in functions so they are consistent with their
> template parameter order and contiguity, per convention.
> - Merge branch 'master' into generation_type
> - Merge branch 'master' into generation_type
> - Missing #include of ShenandoahGenerationType (albeit satisfied transitively via other include).
> - Merge branch 'master' into generation_type
> - Introduce ShenandoahGenerationType and templatize most closures with it.
> The template expands for only the NON_GEN type for the non-generational
> version of Shenandoah currently, and will in the future accomodate
> Generational Shenandoah.
Maybe as a compromise we can review this PR now but only ship it with the rest of Generational Shenandoah, when it arrives? Shouldn't be hard to maintain the PR until then, we don't currently expect many changes in the same code. WDYT?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17815#issuecomment-1957846624
More information about the shenandoah-dev
mailing list