RFR: 8322875: [GenShen] Unused/obsolete method parameter consumed_by_advance_promotion

William Kemper wkemper at openjdk.org
Wed Jan 3 18:16:16 UTC 2024


On Wed, 3 Jan 2024 17:23:13 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> 8322875: [GenShen] Unused/obsolete method parameter consumed_by_advance_promotion
>
> Looks good to me.  (I'm a bit curious about the changes that preceded this one, that made consumed_by_advance_promotion a dead variable.  I'll look into that separately if the "need" arises..)

@kdnilsen , the computed value is still used on line 340:

heap->set_promoted_reserve(consumed_by_advance_promotion);

It's just become a local variable, rather than a parameter.

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/378#issuecomment-1875773904


More information about the shenandoah-dev mailing list