RFR: 8322954: Shenandoah: Convert evac-update closures asserts to rich asserts

[Y. Srinivas Ramakrishna]

On Wed, 3 Jan 2024 14:19:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Over the years, we seem to have introduced new asserts that should really be the rich Shenandoah asserts. I looked around and found at least three places in evac-update closures.
> 
> We also do not need ` _mark_context->is_marked(resolved)` in `ShenandoahEvacUpdateCleanupOopStorageRootsClosure`, because evac-ed objects are supposed to be after TAMS and thus implicitly marked.
> 
> Additional testing:
>  - [x] macos-aarch64-server-fastdebug, `hotspot_gc_shenandoah`
>  - [x] linux-x86_64-server-fastdebug, `tier{1,2,3}` with `-XX:+UseShenandoahGC`

Marked as reviewed by ysr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17245#pullrequestreview-1806384976