RFR: 8323023: GenShen: Region logging test fails intermittently [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Fri Jan 5 17:13:04 UTC 2024
On Fri, 5 Jan 2024 17:01:31 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> This test used to exercise a specific Shenandoah feature, but we've long since rewritten that feature to be based on unified logging. The test doesn't need to retest unified logging features.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>
> Further simplify region logging test
Looks good. Should the test additionally check the contents of one of the files to find a line describing a region snapshot?
-------------
Marked as reviewed by ysr (Committer).
PR Review: https://git.openjdk.org/shenandoah/pull/380#pullrequestreview-1806423263
More information about the shenandoah-dev
mailing list