RFR: 8323630: GenShen: Control thread may (still) ignore requests to start concurrent GC [v3]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Fri Jan 12 17:47:05 UTC 2024
On Fri, 12 Jan 2024 17:23:15 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> A race condition exists in which the control thread may clear the `_requested_gc_cause` immediately after a mutator requests an explicit gc. When this happens, the control thread will no longer accept requests from the regulator to start concurrent GC cycles. The mutator thread will never wakeup, eventually the application will run out of memory or no progress will be made.
>>
>> The change here is intended to simplify the thread communication protocol by reducing the number of variables in play.
>
> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>
> Update comment
Re-reviewed!
🚢
-------------
Marked as reviewed by ysr (Committer).
PR Review: https://git.openjdk.org/shenandoah/pull/382#pullrequestreview-1818755421
More information about the shenandoah-dev
mailing list