RFR: 8321816: GenShen: Provide a minimum amount of time for an old collection to run

Y. Srinivas Ramakrishna ysr at openjdk.org
Sat Jan 13 00:53:52 UTC 2024


On Sat, 13 Jan 2024 00:21:14 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Resolved conflict with `can_unload_classes_normal`.

Looks good.

Not sure why the skara backport script missed a comment only change in src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.hpp; see: https://github.com/openjdk/shenandoah/commit/80f7780bfd2435486a5941629d6b4913b82e60b7?diff=unified&w=0#diff-a904854dfcababbc3df4e7d15da6b9739592176bc27aa053fc197da36b5e8602

Might be a good idea to backport that small hunk as well, for consistency for the future. 

Otherwise looks good.

-------------

Marked as reviewed by ysr (Committer).

PR Review: https://git.openjdk.org/shenandoah-jdk21u/pull/14#pullrequestreview-1819474625


More information about the shenandoah-dev mailing list