RFR: 8324649: Shenandoah: refactor implementation of free set [v4]

[Kelvin Nilsen]

On Sun, 28 Jan 2024 23:09:55 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 41:
>> 
>>> 39:     case Mutator: return "Mutator";
>>> 40:     case Collector: return "Collector";
>>> 41:     case NumFreeSets: return "NumFreeSets";
>> 
>> How is "NumFreeSets" a type whose name would be used? I'd remove it from here.
>
> For the same reason, it seems curious to have "NotFree" be a valid "free memory type". If the types are a partitioning of free memory, they would be FreeMemoryTypes (or more correctly FreeRegionTypes). If they are a partitioning of all regions, they should be RegionTypes and can include both Free and NotFree.

Good points.  I'm removing NumFreeSets case and changing function name to region_type_name().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472107070