RFR: 8324649: Shenandoah: refactor implementation of free set [v4]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jan 31 00:44:03 UTC 2024


On Sun, 28 Jan 2024 23:56:09 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix typo in comment
>>  - Remove unnecessary include
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 163:
> 
>> 161: 
>> 162:   // While holding the heap lock, allocate memory for a single object or LAB  which is to be entirely contained
>> 163:   // within a single HeapRegion as characterized by req.  The req.size() value is known to be less than or
> 
> "known to be", or "required to be"? In other words, is it a precondition of the method to behave correctly?

Rewriting comment to clarify that this is precondition.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472167332


More information about the shenandoah-dev mailing list