RFR: 8324649: Shenandoah: refactor implementation of free set [v4]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Jan 31 01:21:01 UTC 2024
On Mon, 29 Jan 2024 22:46:25 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Fix typo in comment
>> - Remove unnecessary include
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 120:
>
>> 118: }
>> 119:
>> 120: inline void ShenandoahSetsOfFree::shrink_bounds_if_touched(ShenandoahFreeMemoryType set, size_t idx) {
>
> `if_touched` isn't as clear as `if_extremal` -- as far as I can tell you shrink when the region in question is extremal (left or right), at which point you walk right or left, respectively, to get to the next member in the set where you plan the end of that interval.
>
> Or you could just say `shrink_interval_if_at_edge`.
>
> In other words, there's a notion of `touched` here that isn't clear (or at least not obvious to me).
Rename to shrink_range_if_boundary_modified()
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1472192426
More information about the shenandoah-dev
mailing list