RFR: 8336685: Shenandoah: Remove experimental incremental update mode

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jul 24 18:55:32 UTC 2024


On Wed, 24 Jul 2024 18:25:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> We've reason to believe that this mode is very rarely used and its maintenance has become a burden for future development.
>> 
>> ## Testing
>> * hotspot_gc_shenandoah
>> * dacapo
>> * diluvian
>> * extremem
>> * hyperalloc
>> * specjbb2015
>> * specjvm2008
>
> src/hotspot/cpu/ppc/gc/shenandoah/shenandoahBarrierSetAssembler_ppc.cpp line 571:
> 
>> 569:   /* ==== Apply keep-alive barrier, if required (e.g., to inhibit weak reference resurrection) ==== */
>> 570:   if (ShenandoahBarrierSet::need_keep_alive_barrier(decorators, type)) {
>> 571:     if (ShenandoahSATBBarrier) {
> 
> A bit weird to replace IU with SATB barrier here.

Will need_keep_alive_barrier() always be false in absence of IU mode support?  can we replace this with an assert?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20316#discussion_r1690285365


More information about the shenandoah-dev mailing list