RFR: 8336685: Shenandoah: Remove experimental incremental update mode [v4]
William Kemper
wkemper at openjdk.org
Fri Jul 26 15:32:41 UTC 2024
On Thu, 25 Jul 2024 02:27:20 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'openjdk/master' into remove-incremental-update-mode
>> - Simplify final mark now that incremental update mode is removed
>> - Remove unintentional new line
>> - Remove last vestiges of incremental update mode
>> - Missed test, remove actual IU barrier flag
>> - Remove missed iu_barrier usages for C1
>> - Update test (all barriers can be enabled now for all modes)
>> - WIP: Remove incremental update mode
>
> src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp line 339:
>
>> 337: product(bool, ShenandoahIUBarrier, false, DIAGNOSTIC, \
>> 338: "Turn on/off I-U barriers barriers in Shenandoah") \
>> 339: \
>
> Not your change, but these doc comments should really say `"Enable blah-blah ..."` rather than `"Turn on/off blah-blah..."`.
Yes, next time we're in this file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20316#discussion_r1693259588
More information about the shenandoah-dev
mailing list