RFR: 8325673: GenShen: Share Reserves between Old and Young Collector [v6]

[Kelvin Nilsen]

On Thu, 25 Jul 2024 01:02:06 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comment
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahOldHeuristics.cpp line 83:
> 
>> 81: #ifdef ASSERT
>> 82:   if (uint(os::random()) % 100 < ShenandoahCoalesceChance) {
>> 83:     return true;
> 
> The change in the order of the methods has left the diffs very confused, making it a it difficult to read. Would it be possible to restore the old order of definition of these methods, unless there was a specific reason to reorder them? (May be the reordering, if important, could be deferred to a separate PR that only does that; just to make reviewers' lives easier :-)

Sorry for introducing this confusion.  I've re-ordered the methods to make the diffs a bit cleaner.    Some of the refactoring moved part of prime_collection_set() into a helper method.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/395#discussion_r1693966020