RFR: 8331733: [PPC64] saving and restoring CR is not needed at most places

[Varada M]

On Fri, 31 May 2024 14:24:46 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> PPC64 uses save/restore CR less often. Only LR is critical, CR is mainly needed for native-to-Java calls.
>
> src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp line 345:
> 
>> 343:       }
>> 344:     } else if (vm_reg->is_ConditionRegister()) {
>> 345:       // NOP. Conditions registers are covered by save_LR
> 
> This comment is no longer correct. I don't think that we ever save or restore condition registers at this point. So, I think we can replace this comment by `ShouldNotReachHere(); // live condition registers are unexpected at this point`.

Thanks @TheRealMDoerr . I have changed the comment

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19494#discussion_r1625649264