RFR: 8331733: [PPC64] saving and restoring CR is not needed at most places [v2]

Varada M varadam at openjdk.org
Wed Jun 5 10:24:23 UTC 2024


On Wed, 5 Jun 2024 08:22:24 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Thanks for the updates! Sorry, my assumption is wrong. I have found a test which runs into the `ShouldNotReachHere()`: jdk/incubator/vector/VectorMaxConversionTests.java#ZGenerational I think we should revert all changes in `SaveLiveRegisters` (barrierSetAssembler_ppc.cpp) and `XSaveLiveRegisters` (xBarrierSetAssembler_ppc.cpp). We can keep them saving and restoring CR. Sorry for not finding this earlier.

No problem @TheRealMDoerr . Thanks for fix. I have reverted the changes and now the test jdk/incubator/vector/VectorMaxConversionTests.java is passing. I will run tier1 one more time

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19494#issuecomment-2149435569


More information about the shenandoah-dev mailing list