RFR: 8331733: [PPC64] saving and restoring CR is not needed at most places [v5]
Amit Kumar
amitkumar at openjdk.org
Thu Jun 6 12:10:46 UTC 2024
On Thu, 6 Jun 2024 11:24:02 GMT, Varada M <varadam at openjdk.org> wrote:
>> PPC64 uses save/restore CR less often. Only LR is critical, CR is mainly needed for native-to-Java calls.
>> Fastdebug: build and tier1 testing successful. [unrelated failures]
>
> Varada M has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Merge branch 'master' into LR
> - [PPC64] saving and restoring CR is not needed at most places
> - [PPC64] saving and restoring CR is not needed at most places
> - [PPC64] saving and restoring CR is not needed at most places
> - [PPC64] saving and restoring CR is not needed at most places
> - [PPC64] saving and restoring CR is not needed at most places
> - [PPC64] saving and restoring CR is not needed at most places
Looks good to me.
I ran tier1 & vector test on `ppc-le` and these are the results:
failures in tier1 (looks unrelated to this PR):
gtest/GTestWrapper.java
java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java
jdk/javadoc/doclet/testIOException/TestIOException.java
Vector tests:
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
jtreg:./test/jdk/jdk/incubator/vector 78 78 0 0
==============================
TEST SUCCESS
``
-------------
Marked as reviewed by amitkumar (Committer).
PR Review: https://git.openjdk.org/jdk/pull/19494#pullrequestreview-2101765929
More information about the shenandoah-dev
mailing list