RFR: 8333566: Remove unused methods

[Johan Sjölen]

On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

> Please, consider this patch to remove unused methods from the code base. To the best of my knowledge, these methods are only defined but never used.
> 
> Here is a list with names of delete methods: https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874
> 
> Tested with Linux x86_64 tier1-4, GHA, and only cross building to other platforms.

Hi,

Removing dead code is great, but it has to be done with reasoning behind it and preferably in smaller batches, so as to be reviewable. I also don't understand why you comment out tests.

If you can make these into smaller and more localized PRs, then I'll be happy to take a look if I think I'm the right person to review it.

All the best,
Johan

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19550#issuecomment-2154676801