RFR: 8333825: GenShen: Revert/Remove ShenandoahMaxEvacLABRatio

William Kemper wkemper at openjdk.org
Fri Jun 7 18:41:33 UTC 2024


On Fri, 7 Jun 2024 18:24:26 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

> ShenandoahMaxEvacLABRatio was intended as an experimental/research option and guardrail to manually bound the ceiling of PLABs used in Shenandoah and GenShen at the time that GenShen's LAB auto-sizing and allocation heuristics were somewhat nascent and immature. There is however a natural upper-bound of the heap region size for these local allocation buffers which prevent runaway growth, and the manual throttle has never had to be used, and the option thus appears somewhat vestigial. Removing it also reduces differences with upstream Shenandoah which should simplify GenShen's upstreaming reviews.
> 
> - Removed the option and its uses in Shen and GenShen code
> - Adjusted logging to be consistent, and adjusted some comments in GenShen
> - Tested with codepipeline, GC tests, and exercised the new log lines

LGTM

-------------

Marked as reviewed by wkemper (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/446#pullrequestreview-2105170521


More information about the shenandoah-dev mailing list