RFR: 8333750: GenShen: Only instantiate young/old generations in generational mode [v3]

William Kemper wkemper at openjdk.org
Mon Jun 10 18:31:39 UTC 2024


On Mon, 10 Jun 2024 17:07:49 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Make age and youth const
>>  - Do not age regions after completing old mark
>>  - Detect cancellation of old GC after final mark.
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGC.cpp line 119:
> 
>> 117:     return false;
>> 118:   }
>> 119: 
> 
> This looks like it might be a bug fix, vs the rest of this PR, which is mostly isolation refactoring.  Should the bug fix be separated out into a different PR?

Yes, it is a bug fix. I'll pull it out into a separate PR.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/444#discussion_r1633672241


More information about the shenandoah-dev mailing list