RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

William Kemper wkemper at openjdk.org
Mon Jun 17 20:38:26 UTC 2024


On Thu, 13 Jun 2024 22:22:01 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> The mainline implementation of ShenandoahFreeSet was recently updated.  This PR integrates the upstream changes
>> into Generational Shenandoah.
>
> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor refinements to test programs
>   
>   TestAllocIntArrays: comments to explain behavior.
>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>   will not time out on less powerful test platforms.

test/hotspot/jtreg/gc/shenandoah/TestAllocIntArrays.java line 211:

> 209:         final int max = 384 * 1024;
> 210:         // Each allocated int array is assumed to consume 16 bytes for alignment and header, plus
> 211:         //  an everage of 4 * the average number of elements in the array.

s/everage/average

test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java line 49:

> 47:             List<Object> root = new ArrayList<Object>();
> 48:             while (true) {
> 49:               root.add(new Object[SIZE]);

Accidental? Rest of file uses 4 spaces for indent.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1643402343
PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1643403554


More information about the shenandoah-dev mailing list