RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Jun 19 22:53:27 UTC 2024


On Wed, 19 Jun 2024 01:16:02 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 382:
> 
>> 380:   // of the regions recycled from the collection set will be available.  In the very unlikely event that there
>> 381:   // are fewer regions in the collection set than remain in the collector's free set, we limit the transfer in order
>> 382:   // to assure that the replenished Collector reserves can be sufficiently large.
> 
> Apropos my previous comment, this part would seem to belong in the caller(s?) of the method.

I'm moving a variation of this comment to the callers.  Thanks.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1646737669


More information about the shenandoah-dev mailing list