RFR: 8328235: GenShen: Robustify ShenandoahGCSession and fix missing use [v3]

[Y. Srinivas Ramakrishna]

On Fri, 17 May 2024 17:23:34 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 32 commits:
>> 
>>  - jcheck whitespace
>>  - Fixed mismerge because of code moving between files in merge from
>>    master; encapsulate assert & provide more useful debugging info. We
>>    aren't done yet... It might be the case that we do away with the
>>    sync/async split of the variable and instead move the relevant state
>>    into the closure if possible. That might have to wait for another day
>>    though based on whether it'll work well everywhere or not.
>>  - Merge branch 'master' into active_generation
>>  - Greater separation of gc_generation and active_generation fields of
>>    ShHeap. WIP.
>>  - Clean ups.
>>  - jcheck whitespace
>>  - Banish forcing entirely. Fix one case where full gc sets
>>    active_generation directly. Might be other cases as well. Will need a
>>    cleaner and more natural abstraction different from the unseemly
>>    under-the-covers groveling that we do currently.
>>  - Relax an assert that is too strong; still iterating execution paths,
>>    more cleanups planned.
>>  - Disallow forcing.
>>    Test.
>>  - Remove an incorrect gc status setting.
>>  - ... and 22 more: https://git.openjdk.org/shenandoah/compare/dfa78866...61848c82
>
> test/hotspot/jtreg/gc/shenandoah/oom/TestThreadFailure.java line 81:
> 
>> 79:             ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(
>> 80:                     "-Xmx32m",
>> 81:                     // "-XX:+UnlockExperimentalVMOptions", "-XX:ShenandoahNoProgressThreshold=12", "-XX:+ShowMessageBoxOnError",
> 
> Ignore this. Will be removed; debugging detritus left in place until we believe we are ready.

Removed in latest. Resolving.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/407#discussion_r1646834814