RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

[Kelvin Nilsen]

On Wed, 19 Jun 2024 01:34:38 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 408:
> 
>> 406:   // capacity as NotFree.  Subsequently, we will move some of the mutator regions into the collector and old collector
>> 407:   // partitions with the intent of packing old collector memory into the highest (far rightmost) addresses of the heap,
>> 408:   // young collector memory into higher address, and mutator memory consuming the lowest addresses of the heap.
> 
> Is the part of the comment that starts at "Subsequently, we will ..." done as part of this method? If not, then it should go into the caller of this method (after this method is called), rather than stating what the caller will do. I'd keep documentation of these methods very simple: what its parms are and what it does.

Thanks.  I've adjusted the comments as guided.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1647927053