RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v8]

Kelvin Nilsen kdnilsen at openjdk.org
Thu Jun 20 18:07:38 UTC 2024


On Wed, 19 Jun 2024 01:47:49 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor refinements to test programs
>>   
>>   TestAllocIntArrays: comments to explain behavior.
>>   TestOldGrowthTriggers: reduce the number of loop iterations so this test
>>   will not time out on less powerful test platforms.
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 423:
> 
>> 421: 
>> 422: 
>> 423:   void reserve_regions(size_t young_reserve, size_t old_reserve);
> 
> Is the old variant without the var parameter still used somewhere?

Good catch.  That is no longer relevant.  Removing.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/440#discussion_r1647956646


More information about the shenandoah-dev mailing list