RFR: 8327000: GenShen: Integrate updated Shenandoah implementation of FreeSet into GenShen [v27]

William Kemper wkemper at openjdk.org
Tue Jun 25 21:42:33 UTC 2024


On Tue, 25 Jun 2024 16:18:59 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> The mainline implementation of ShenandoahFreeSet was recently updated.  This PR integrates the upstream changes
>> into Generational Shenandoah.
>
> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve consistency of OOM in GenShen mode
>   
>   Treat any full GC that enables a previously blocked allocation as good
>   progress.

The other side of the oom issue is test failures and timeouts caused by Shenandoah not giving up soon enough. If I recall correctly, there were three tests that would fail because they did _not_ raise an OOME when expected. Could we also run:

make test TEST="runtime/ClassInitErrors/TestOutOfMemoryDuringInit.java compiler/uncommontrap/TestDeoptOOM.java runtime/reflect/ReflectOutOfMemoryError.java" TEST_VM_OPTS="-Xlog:gc:file=/tmp/shen.log -XX:+UseShenandoahGC"

and for genshen:

make test TEST="runtime/ClassInitErrors/TestOutOfMemoryDuringInit.java compiler/uncommontrap/TestDeoptOOM.java runtime/reflect/ReflectOutOfMemoryError.java" TEST_VM_OPTS="-Xlog:gc:file=/tmp/shen.log -XX:+UseShenandoahGC -XX:ShenandoahGCMode=generational"

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/440#issuecomment-2190015491


More information about the shenandoah-dev mailing list