RFR: 8333133: Simplify QuickSort::sort [v3]
Kim Barrett
kbarrett at openjdk.org
Wed Jun 26 05:21:29 UTC 2024
On Tue, 11 Jun 2024 05:32:03 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Merge branch 'master' into no-idempotent-quicksort
>> - Merge branch 'master' into no-idempotent-quicksort
>> - improve find_pivot description
>> - remove idempotent
>
> src/hotspot/share/utilities/quickSort.hpp line 43:
>
>> 41: // We swap these three values into the right place in the array. This
>> 42: // means that this method not only returns the index of the pivot
>> 43: // element. It also alters the array so that:
>
> Pre-existing nit: this should be one sentence: "... element, it also ..."
I ended up doing a rewrite of the description.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19464#discussion_r1654047792
More information about the shenandoah-dev
mailing list