RFR: 8325885: GenShen: harmonize with JDK-8325671

Kelvin Nilsen kdnilsen at openjdk.org
Mon Mar 4 21:48:18 UTC 2024


On Sat, 2 Mar 2024 02:15:53 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

> /issueJDK-8325885

Looks good to me.  Thanks.

src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 244:

> 242:   ShenandoahFlushSATBHandshakeClosure flush_satb(qset);
> 243:   for (uint flushes = 0; flushes < ShenandoahMaxSATBBufferFlushes; flushes++) {
> 244:     // TODO: ysr : hoist this switch out of the loop & refactor ?? How may

The default value of ShenandoahMaxSATBBufferFlushes is 5.  I think the number of iterations is typically low.  Given low number of typical iterations, may not be worth it to restructure the loop control.

-------------

Marked as reviewed by kdnilsen (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/402#pullrequestreview-1915411815
PR Review Comment: https://git.openjdk.org/shenandoah/pull/402#discussion_r1511836937


More information about the shenandoah-dev mailing list