RFR: 8325885: GenShen: harmonize with JDK-8325671 [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Tue Mar 5 17:55:15 UTC 2024
On Tue, 5 Mar 2024 17:46:25 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 244:
>>
>>> 242: ShenandoahFlushSATBHandshakeClosure flush_satb(qset);
>>> 243: for (uint flushes = 0; flushes < ShenandoahMaxSATBBufferFlushes; flushes++) {
>>> 244: // TODO: ysr : hoist this switch out of the loop & refactor ?? How may
>>
>> The default value of ShenandoahMaxSATBBufferFlushes is 5. I think the number of iterations is typically low. Given low number of typical iterations, may not be worth it to restructure the loop control.
>
> Good point, I'll clear this comment which was inadvertently left behind here.
>
> To your point, the cost of the switch is far far lower than the work done inside each case statement, so any fears of cost when I initially wrote that comment are overblown.
Done.
-------------
PR Review Comment: https://git.openjdk.org/shenandoah/pull/402#discussion_r1513257958
More information about the shenandoah-dev
mailing list