RFR: 8324649: Shenandoah: refactor implementation of free set [v4]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Mar 13 18:24:20 UTC 2024


On Sun, 28 Jan 2024 23:42:47 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix typo in comment
>>  - Remove unnecessary include
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 168:
> 
>> 166:   HeapWord* allocate_contiguous(ShenandoahAllocRequest& req);
>> 167: 
>> 168:   void flip_to_gc(ShenandoahHeapRegion* r);
> 
> Document the contract(s) of this method.

Thanks.  I've added a comment to the .hpp file to describe this function's behavior.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1523722271


More information about the shenandoah-dev mailing list