RFR: 8324649: Shenandoah: refactor implementation of free set [v30]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Mar 13 18:24:22 UTC 2024
On Fri, 1 Mar 2024 18:00:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Move comments that describe functions into header file
>>
>> Also, remove redundant comments from the .cpp and inline-hpp files.
>> - Reduce strength of bit manipulation operations
>>
>> Replace /, %, and * with >>, &, <<.
>> - Use existing macros for bit twiddling
>
> src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 1089:
>
>> 1087: heap->heap_region_iterate(&post_compact);
>> 1088: heap->set_used(post_compact.get_live());
>> 1089:
>
> Is this change necessary?
Sorry. Reverted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1523725007
More information about the shenandoah-dev
mailing list