RFR: 8324649: Shenandoah: refactor implementation of free set [v14]

Kelvin Nilsen kdnilsen at openjdk.org
Wed Mar 13 18:56:39 UTC 2024


On Wed, 13 Mar 2024 18:50:17 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 1152:
>> 
>>> 1150:   _partitions.retire_range_from_partition(Mutator, beg, end);
>>> 1151: 
>>> 1152:   size_t total_humongous_size = ShenandoahHeapRegion::region_size_bytes() * num;
>> 
>> Lost the original comment. Also, where did the call to `notify_mutator_alloc_words` went?
>
> Good catch.  I've added the call to notify_mutator_alloc_words() back in.  I've also added a comment to clarify that retire_range_from_partition() adjusts the bounds if necessary.

Fixed.  Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1523766561


More information about the shenandoah-dev mailing list