RFR: 8328220: GenShen: Move generational mode operational parameters out of ShenandoahHeap [v2]

Y. Srinivas Ramakrishna ysr at openjdk.org
Tue Mar 19 20:13:49 UTC 2024


On Tue, 19 Mar 2024 00:10:14 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahYoungHeuristics.cpp line 82:
>> 
>>> 80:                                                             size_t cur_young_garbage) const {
>>> 81: 
>>> 82:   auto heap = ShenandoahGenerationalHeap::heap();
>> 
>> I have noticed that you "auto" in a few places but not in others (any reason why it's been done selectively? :-). Is there a more desirable end-state between the possible idiomatic alternatives?
>
> It should mostly be in places where I wanted the declared type to be `ShenandoahGenerationalHeap`.

ok thanks that makes sense.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/406#discussion_r1531033927


More information about the shenandoah-dev mailing list