RFR: 8328220: GenShen: Move generational mode operational parameters out of ShenandoahHeap [v2]

[William Kemper]

On Mon, 18 Mar 2024 23:44:01 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve comments, make more variables const.
>
> src/hotspot/share/gc/shenandoah/shenandoahGenerationalHeap.cpp line 120:
> 
>> 118: }
>> 119: 
>> 120: ShenandoahGenerationalHeap::TransferResult ShenandoahGenerationalHeap::balance_generations() {
> 
> To a related comment on signed value of surplus (or deficit, as you will), one might probably change this if its only current role is to carry the directional information (by compressing all of that information into a sign, with canonical direction based on convention). You could still use this to make logging easier, though.

I'll pick up the surplus/deficit change in a subsequent PR.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/406#discussion_r1531112442