RFR: 8324649: Shenandoah: refactor implementation of free set [v32]

[Kelvin Nilsen]

On Wed, 13 Mar 2024 19:49:21 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove comment that pertains only to generational mode
>>  - Rewrite comment describing rationale for Collector free set membership
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.inline.hpp line 1:
> 
>> 1: /*
> 
> I don't think any of the code in shenandoahFreeSet.inline.hpp is public/used by any code outside of shenandoahFreeSet.cpp, which means that all of it should go into shenandoahFreeSet.cpp. The methods can still be 'inline'. The convention for .inline.hpp is mostly used to allow sharing inlined code and resolving circular dependencies.

I made some of these services "public" so that googletest can exercise the APIs from test/hotspot/gtest/gc/shenandoah/shenandoahSimpleBitMap.cpp.  Please advise if there's a better way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1532758788