RFR: JDK-8241503: C2: Share MacroAssembler between mach nodes during code emission [v10]

Cesar Soares Lucas cslucas at openjdk.org
Fri Mar 22 18:19:39 UTC 2024


> # Description
> 
> Please review this PR with a patch to re-use the same C2_MacroAssembler object to emit all instructions in the same compilation unit.
> 
> Overall, the change is pretty simple. However, due to the renaming of the variable to access C2_MacroAssembler, from `_masm.` to `masm->`, and also some method prototype changes, the patch became quite large.
> 
> # Help Needed for Testing
> 
> I don't have access to all platforms necessary to test this. I hope some other folks can help with testing on `S390`, `RISC-V` and `PPC`.

Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:

  Fix AArch64 build & improve comment about InstructionMark

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16484/files
  - new: https://git.openjdk.org/jdk/pull/16484/files/aa80c801..e763b089

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16484&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16484&range=08-09

  Stats: 4 lines in 3 files changed: 1 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/16484.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16484/head:pull/16484

PR: https://git.openjdk.org/jdk/pull/16484


More information about the shenandoah-dev mailing list