RFR: JDK-8241503: C2: Share MacroAssembler between mach nodes during code emission [v9]

Cesar Soares Lucas cslucas at openjdk.org
Fri Mar 22 18:19:42 UTC 2024


On Fri, 22 Mar 2024 17:58:36 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Catching up with changes in master
>>  - Catching up with origin/master
>>  - Catch up with origin/master
>>  - Merge with origin/master
>>  - Fix build, copyright dates, m4 files.
>>  - Fix merge
>>  - Catch up with master branch.
>>    
>>    Merge remote-tracking branch 'origin/master' into reuse-macroasm
>>  - Some inst_mark fixes; Catch up with master.
>>  - Catch up with changes on master
>>  - Reuse same C2_MacroAssembler object to emit instructions.
>
> GHA shows issue with Aarch64 builds on MacOS and Windows:
> 
> d:\a\jdk\jdk\build\windows-aarch64\hotspot\variant-server\gensrc\adfiles\ad_aarch64.cpp(24257): error C2653: 'CompiledStaticCall': is not a class or namespace name
> d:\a\jdk\jdk\build\windows-aarch64\hotspot\variant-server\gensrc\adfiles\ad_aarch64.cpp(24257): error C3861: 'emit_to_interp_stub': identifier not found

@vnkozlov - I was working on that. It was because of a typo. Now it's fixed.

Can I please get more reviews on this? Pinging port maintainer: /cc @theRealAph @nick-arm @bulasevich @snazarkin @offamitkumar @RealLucy

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16484#issuecomment-2015657375


More information about the shenandoah-dev mailing list