RFR: 8328626: GenShen: Combine old generation surplus/deficit fields into a single balance field [v2]

[William Kemper]

On Mon, 25 Mar 2024 16:17:58 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 1185:
>> 
>>> 1183: void ShenandoahFreeSet::compute_young_and_old_reserves(size_t young_cset_regions, size_t old_cset_regions,
>>> 1184:                                                        bool have_evacuation_reserves, size_t* young_reserve_result,
>>> 1185:                                                        size_t* old_reserve_result) const {
>> 
>> Might read more "naturally" if args declared as:
>> 
>> size_t& young_reserve_result, size_t& old_reserve_result
>
> Hmm, I usually see 'result' parameters like this passed as pointers in the JDK. It makes it clearer at the call site. Or did you mean to format them on the same line?

Never mind, I see this class uses references for such parameters. I'll change it for sake of consistency.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/410#discussion_r1537871699