RFR: 8328626: GenShen: Combine old generation surplus/deficit fields into a single balance field [v3]

[Y. Srinivas Ramakrishna]

On Mon, 25 Mar 2024 18:20:59 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> This is a follow up to https://github.com/openjdk/shenandoah/pull/406.
>
> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Consolidate region transfer logic, move generational specific code out of ShenandoahHeap
>  - Use pass by reference for consistency with other methods

LGTM; thanks!

src/hotspot/share/gc/shenandoah/shenandoahMmuTracker.hpp line 128:

> 126:   void recalculate_min_max_young_length(size_t heap_region_count);
> 127: 
> 128:   bool transfer_regions(ShenandoahGeneration* src, ShenandoahGeneration* dst, size_t regions) const;

Transfer regions has a bit of nuance, in that it fails without affecting the transfer if the transfer won't succeed without violating source or destination size bounds. I'd explain when it returns true and when false in a documentation line here.

-------------

Marked as reviewed by ysr (Committer).

PR Review: https://git.openjdk.org/shenandoah/pull/410#pullrequestreview-1958652838
PR Review Comment: https://git.openjdk.org/shenandoah/pull/410#discussion_r1538154047