RFR: JDK-8241503: C2: Share MacroAssembler between mach nodes during code emission [v10]
Boris Ulasevich
bulasevich at openjdk.org
Tue Mar 26 15:00:27 UTC 2024
On Fri, 22 Mar 2024 18:19:39 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> # Description
>>
>> Please review this PR with a patch to re-use the same C2_MacroAssembler object to emit all instructions in the same compilation unit.
>>
>> Overall, the change is pretty simple. However, due to the renaming of the variable to access C2_MacroAssembler, from `_masm.` to `masm->`, and also some method prototype changes, the patch became quite large.
>>
>> # Help Needed for Testing
>>
>> I don't have access to all platforms necessary to test this. I hope some other folks can help with testing on `S390`, `RISC-V` and `PPC`.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix AArch64 build & improve comment about InstructionMark
Hi! Your change has conflict with current jdk master. Please rebase.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16484#issuecomment-2020665067
More information about the shenandoah-dev
mailing list