RFR: 8327097: GenShen: Align PLAB sizes down rather than up [v13]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Wed Mar 27 06:49:39 UTC 2024
On Tue, 26 Mar 2024 15:37:02 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> When adjusting LAB sizes, round down rather than rounding up. Otherwise, we may violate the ShenandoahHumongousThreshold bound.
>
> Kelvin Nilsen has updated the pull request incrementally with four additional commits since the last revision:
>
> - Add a missing include to fix zero build
> - Add TODO comment for future refactoring of _plab initialization
> - Bug fixes to address regressions encountered during integration testing
> - Tighten up assert to assist with debugging
LGTM
-------------
Marked as reviewed by ysr (Committer).
PR Review: https://git.openjdk.org/shenandoah/pull/401#pullrequestreview-1962441794
More information about the shenandoah-dev
mailing list