RFR: 8328507: Move StackWatermark code from safepoint cleanup [v2]

[Coleen Phillimore]

On Tue, 19 Mar 2024 14:41:33 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> There is some stack watermark code in safepoint cleanup that flushes out concurrent stack processing, as a defensive measure to guard safepoint operations that assume the stacks have been fixed up. However, we wish to get rid of safepoint cleanup so this operation should move out from the safepoint. This proposal moves it into CollectedHeap::safepoint_synchronize_begin instead which runs before we start shutting down Java threads. This moves the code into more obvious GC places and reduces time spent inside of non-GC safepoints.
>
> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove incorrect assert

This makes sense.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18378#pullrequestreview-1964934082