Integrated: 8328507: Move StackWatermark code from safepoint cleanup

Erik Österlund eosterlund at openjdk.org
Thu Mar 28 14:14:39 UTC 2024


On Tue, 19 Mar 2024 13:30:39 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> There is some stack watermark code in safepoint cleanup that flushes out concurrent stack processing, as a defensive measure to guard safepoint operations that assume the stacks have been fixed up. However, we wish to get rid of safepoint cleanup so this operation should move out from the safepoint. This proposal moves it into CollectedHeap::safepoint_synchronize_begin instead which runs before we start shutting down Java threads. This moves the code into more obvious GC places and reduces time spent inside of non-GC safepoints.

This pull request has now been integrated.

Changeset: aa595dbd
Author:    Erik Österlund <eosterlund at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/aa595dbda4e64d76eeaff941b2f1e1ef2414d7af
Stats:     76 lines in 11 files changed: 23 ins; 45 del; 8 mod

8328507: Move StackWatermark code from safepoint cleanup

Reviewed-by: aboldtch, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/18378


More information about the shenandoah-dev mailing list