RFR: 8324649: Shenandoah: refactor implementation of free set [v38]

Kelvin Nilsen kdnilsen at openjdk.org
Thu Mar 28 16:06:58 UTC 2024


On Tue, 26 Mar 2024 16:44:25 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 53:
>> 
>>> 51:   uintx omit_mask = right_n_bits(bit_number);
>>> 52:   uintx mask = ((uintx) 0 - 1) & ~omit_mask;
>>> 53: #undef KELVIN_DEBUG
>> 
>> Please remove KELVIN_DEBUG before integration. You may want to turn it into proper logging, if you think it may be useful.
>
> log_*_develop() is only built in debug builds, that may be useful.

Thanks for that catch.  Removing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17561#discussion_r1543223245


More information about the shenandoah-dev mailing list