RFR: 8331609: GenShen: Refactor generational mode allocations [v2]

William Kemper wkemper at openjdk.org
Tue May 7 21:21:25 UTC 2024


On Mon, 6 May 2024 20:32:28 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix zero build, warnings in test
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGeneration.cpp line 237:
> 
>> 235: 
>> 236:   if (req.type() == ShenandoahAllocRequest::_alloc_plab) {
>> 237:     // The promotion reserve is exhausted. Check if we still have room for evacuations.
> 
> We don't KNOW promotion reserve is entirely exhausted, just that what remains in promotion reserve is less than requested bytes.

Fixed comment.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/427#discussion_r1593106661


More information about the shenandoah-dev mailing list